Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pop-count: rename to eliuds-eggs #1436

Merged
merged 5 commits into from
Feb 3, 2024
Merged

Conversation

ErikSchierboom
Copy link
Member

We are renaming the pop-count exercise to eliuds-eggs. See exercism/problem-specifications#2382 for more information.


This PR renames pop-count to eliuds-eggs. We have attempted to rename everything that is automatable, but you may need to make specific changes in the files.

If you could prioritise finishing and merging this, we would be grateful, so we can get the exercise in the correct state across Exercism. Please let me know if you have any questions.

Thanks! 🙂

@ErikSchierboom ErikSchierboom added the x:size/tiny Tiny amount of work label Feb 2, 2024
Copy link
Contributor

github-actions bot commented Feb 2, 2024

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps

    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)
  • Any exercise changed

    • 👤 Does the author of the PR need to be added as an author or contributor in <exercise>/.meta/config.json (see docs)?
    • 🔬 Do the analyzer and the analyzer comments exist for this exercise? Do they need to be changed?
    • 📜 Does the design file (<exercise>/.meta/design.md) need to be updated to document new implementation decisions?
  • Practice exercise changed

    • 🌲 Do prerequisites, practices, and difficulty in config.json need to be updated?
    • 🧑‍🏫 Are the changes in accordance with the community-wide problem specifiations?
  • Practice exercise tests changed

    • ⚪️ Are all tests except the first one skipped?
    • 📜 Does <exercise>/.meta/tests.toml need updating?

Automated comment created by PR Commenter 🤖.

@jiegillet jiegillet self-assigned this Feb 3, 2024
@jiegillet
Copy link
Contributor

Thanks for reviewing @angelikatyborska. I made so many mistakes working on this, I had no confidence 😅

@jiegillet jiegillet merged commit 24d2fbb into main Feb 3, 2024
10 checks passed
@jiegillet jiegillet deleted the rename-pop-count-to-eliuds-eggs branch February 3, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:size/tiny Tiny amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants