Merge pull request #151 from dalexj/clearer-sum-of-multiples

Get rid of sum of multiples default arguments

exercises/sum-of-multiples/example.exs

@@ -2,11 +2,9 @@ defmodule SumOfMultiples do
 
   @doc """
   Adds up all numbers from 1 to a given end number that are multiples of the factors provided.
-
-  The default factors are 3 and 5.
   """
   @spec to(non_neg_integer, [non_neg_integer]) :: non_neg_integer
-  def to(limit, factors \\ [3, 5]) do
+  def to(limit, factors) do
     Enum.reduce(1..limit-1, 0, fn(n, acc) ->
       if Enum.any?(factors, &(rem(n, &1) == 0)), do: acc + n, else: acc end)
   end

exercises/sum-of-multiples/sum_of_multiples.exs

@@ -1,11 +1,9 @@
 defmodule SumOfMultiples do
   @doc """
   Adds up all numbers from 1 to a given end number that are multiples of the factors provided.
-
-  The default factors are 3 and 5.
   """
   @spec to(non_neg_integer, [non_neg_integer]) :: non_neg_integer
-  def to(limit, factors \\ [3, 5]) do
-    
+  def to(limit, factors) do
+
   end
 end

exercises/sum-of-multiples/sum_of_multiples_test.exs

@@ -10,32 +10,32 @@ defmodule SumOfMultiplesTest do
 
   # @tag :pending
   test "sum to 1" do
-    assert SumOfMultiples.to(1) == 0
+    assert SumOfMultiples.to(1, [3, 5]) == 0
   end
 
   @tag :pending
   test "sum to 3" do
-    assert SumOfMultiples.to(4) == 3
+    assert SumOfMultiples.to(4, [3, 5]) == 3
   end
 
   @tag :pending
   test "sum to 10" do
-    assert SumOfMultiples.to(10) == 23
+    assert SumOfMultiples.to(10, [3, 5]) == 23
   end
 
   @tag :pending
   test "sum to 20" do
-    assert SumOfMultiples.to(20) == 78
+    assert SumOfMultiples.to(20, [3, 5]) == 78
   end
 
   @tag :pending
   test "sum to 100" do
-    assert SumOfMultiples.to(100) == 2318
+    assert SumOfMultiples.to(100, [3, 5]) == 2318
   end
 
   @tag :pending
   test "sum to 1000" do
-    assert SumOfMultiples.to(1000) == 233168
+    assert SumOfMultiples.to(1000, [3, 5]) == 233168
   end
 
   @tag :pending