Explain how to name concept exercises #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikSchierboom
force-pushed
the
naming-concept-exercises
branch
from
4807bec to
e269a9a
Compare
ErikSchierboom
force-pushed
the
naming-concept-exercises
branch
from
e269a9a to
8d31544
Compare
SaschaMann
reviewed
Mar 2, 2021
Comment on lines
+484
to
+488
| Bad examples of slugs: | ||
|
|
||
| - `TIM-FROM-MARKETING`: should use lowercase (i.e. `tim-from-marketing`) | ||
| - `TimFromMarketing`: should use kebab-case (i.e. `tim-from-marketing`) | ||
| - `floating-point-numbers`: should not use a concept |
There was a problem hiding this comment.
Must the slugs follow the rules above or should they follow those rules?
The paragraph above suggests they must follow those rules, but these examples suggest they're optional.
There was a problem hiding this comment.
must.
Suggested change
| Bad examples of slugs: | |
| - `TIM-FROM-MARKETING`: should use lowercase (i.e. `tim-from-marketing`) | |
| - `TimFromMarketing`: should use kebab-case (i.e. `tim-from-marketing`) | |
| - `floating-point-numbers`: should not use a concept | |
| Bad examples of slugs: | |
| - `TIM-FROM-MARKETING`: does not use lowercase (i.e. `tim-from-marketing`) | |
| - `TimFromMarketing`: does not use kebab-case (i.e. `tim-from-marketing`) | |
| - `floating-point-numbers`: uses a concept name not a story name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.