Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add knapsack exercise #253

Merged
merged 1 commit into from
Jun 22, 2024
Merged

Add knapsack exercise #253

merged 1 commit into from
Jun 22, 2024

Conversation

keiravillekode
Copy link
Contributor

No description provided.

@BNAndras BNAndras added x:module/practice-exercise Work on Practice Exercises x:rep/large Large amount of reputation labels Jun 22, 2024
@BNAndras BNAndras merged commit 345d9a8 into exercism:main Jun 22, 2024
5 checks passed
@keiravillekode
Copy link
Contributor Author

I tried to submit my knapsack solution through the Exercism website, and received compile errors in the tests:

 Error: found `:` when expecting `,`

I can change the tests to replace

Item(weight: 120, value: 240)

with

Item(120, 240)

Less urgently, we might consider updating the D compiler used by Exercism.

@BNAndras
Copy link
Member

The CI targets the latest version which isn’t good. We should target specific versions or use the test runner image to test the exercises.

@BNAndras
Copy link
Member

I added PRs to pin the CI's dmd version for this repo and to also upgrade the Docker image to dmd 2.109.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BNAndras BNAndras BNAndras approved these changes

Assignees
No one assigned
Labels
x:module/practice-exercise Work on Practice Exercises x:rep/large Large amount of reputation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keiravillekode @BNAndras