Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump DMD to 2.109.0 #66

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Conversation

BNAndras
Copy link
Member

No description provided.

@BNAndras BNAndras added the x:module/test-runner Work on Test Runners label Jun 23, 2024
@BNAndras BNAndras requested a review from a team as a code owner June 23, 2024 03:02
@BNAndras
Copy link
Member Author

I went for the external repo to simplify things. Alpine has 2.104 so I went with Ubuntu 24.04 to get 2.109.0. There's an official download script available on https://dlang.org/download.html, but we'd still need to get a copy of DUB. There are releases from GitHub we can source like https://github.com/dlang/dub/releases/tag/v1.38.0.

Dockerfile Outdated Show resolved Hide resolved
@@ -23,6 +23,7 @@ docker run \
--read-only \
--mount type=bind,src="${PWD}/tests",dst=/opt/test-runner/tests \
--mount type=tmpfs,dst=/tmp \
--mount type=tmpfs,dst=/root/.dub \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work in production as this flag won't be passed. Would not passing the readonly flag fix it? If so, feel free to remove that flag and see if that fixes it, as we're technically not yet passing that flag in production.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was getting an error about that folder being a read only location even if i made the whole image writable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you need to check which user is running the image vs. the permissions on that folder?

@BNAndras BNAndras merged commit 6399d21 into exercism:main Jul 1, 2024
1 check passed
@BNAndras BNAndras deleted the update-docker-image branch July 1, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:module/test-runner Work on Test Runners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants