-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump DMD to 2.109.0 #66
Conversation
I went for the external repo to simplify things. Alpine has 2.104 so I went with Ubuntu 24.04 to get 2.109.0. There's an official download script available on https://dlang.org/download.html, but we'd still need to get a copy of DUB. There are releases from GitHub we can source like https://github.com/dlang/dub/releases/tag/v1.38.0. |
bin/run-tests-in-docker.sh
Outdated
@@ -23,6 +23,7 @@ docker run \ | |||
--read-only \ | |||
--mount type=bind,src="${PWD}/tests",dst=/opt/test-runner/tests \ | |||
--mount type=tmpfs,dst=/tmp \ | |||
--mount type=tmpfs,dst=/root/.dub \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work in production as this flag won't be passed. Would not passing the readonly flag fix it? If so, feel free to remove that flag and see if that fixes it, as we're technically not yet passing that flag in production.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was getting an error about that folder being a read only location even if i made the whole image writable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you need to check which user is running the image vs. the permissions on that folder?
No description provided.