largest-series-product: Do not test digits/slices #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The digits and slices functions are internal implementation details and thus the test case for the largest-series-product problem should not be concerned with testing them. The series tests could potentially be moved to the series exercise (already implemented by this track). Their presence may cause students to falsely think that their solution has to use these two functions, instead of the alternative implementation of only iterating through the digits once. If it is desired to give hints on how to approach this problem (which was one advantage of having the digits and slices tests), then consider including a hints file and/or directory in the largest-series-product directory. This PR arises from discussion in exercism/problem-specifications#192
These were tested via GetSlices previously, but they should also be tested via GetLargestProduct. The GetSlices tests were removed in a previous commit.
bressain
added a commit
that referenced
this pull request
Mar 13, 2016
largest-series-product: Do not test digits/slices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The digits and slices functions are internal implementation details and
thus the test case for the largest-series-product problem should not be
concerned with testing them. The series tests could potentially be moved
to the series exercise (already implemented by this track).
Their presence may cause students to falsely think that their solution
has to use these two functions, instead of the alternative
implementation of only iterating through the digits once.
If it is desired to give hints on how to approach this problem (which
was one advantage of having the digits and slices tests), then consider
including a hints file and/or directory in the largest-series-product
directory.
This PR arises from discussion in
exercism/problem-specifications#192