Add more tests to LandGrabInSpaceTests.cs

[cizra]

See discussion at https://forum.exercism.org/t/land-grab-in-space-has-insufficient-test-coverage-for-the-plot-with-longest-side/9615

[github-actions]

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.

---

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

[github-actions]

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

[ErikSchierboom]

Thanks!

[Naeddyr]

Adding these tests made the "learning exercise" significantly harder. A better solution would be to add a guarantee that the coordinates of the plot are always in the correct order.

[cizra]

Adding these tests made the "learning exercise" significantly harder. A better solution would be to add a guarantee that the coordinates of the plot are always in the correct order.

Disagreed, @Naeddyr - before adding these tests, the most difficult task in the exercise could be completed by just returning the 1st element of the list, which is not in the spirit of the task. The task was about calculating sizes of plots, and this just wasn't necessary. To be honest, the bit with dialog could have been skipped, tho.

[Naeddyr]

The diagonals test makes this learning exercise (originally about hash sets and hashing and marginally about the data itself) an intermediate exercise about generating a convex polygon from a set of points or coming up with some other algorithm. You shouldn't just add a completely new category of test because it feels right. The correct way to do this would have been to make the old tests better. Randomize the elements of the list, add more elements to the list, that sort of thing.

EDIT: Apologies if this seems hostile, I was just really frustrated with the diagonals test.

EDIT: I just realized you typoed "diagonals" as "dialog", and I didn't realize you were agreeing. Sorry about this reply.