Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: added test case to acronym exercise to cover missed case #523

Closed
wants to merge 1 commit into from

Conversation

Llcoolsouder
Copy link

The current iteration of the acronym exercise missed the case where the first letter of the phrase is lowercase.

I had a mentee start their solution with

std::string result(1, input[0]);

and all tests passed.

My new test accounts for this situation.

@siebenschlaefer
Copy link
Contributor

The C++ track (usually) just translates the test cases from the language-agnostic problem specification to C++.
The best place to suggest changes like this is at github.com/exercism/problem-specifications/issues.

BTW: Two somehow related suggestions already exist: #1431 and #1432.

@kytrinyx
Copy link
Member

@Llcoolsouder Thanks for the suggestion!

If you would like to propose these changes in problem-specifications, please open an issue there.
If they get accepted upstream, then we will update the test suite here to include them.

I'm going to go ahead and close this.

@kytrinyx kytrinyx closed this Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants