Refactor(cli): Reduce duplication #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to be more consistent with the valid values for the corresponding CLI option (`--mode=include` and `--mode=exclude`).
|
@ee7 Let me know when you want this to be reviewed. |
ErikSchierboom
approved these changes
Oct 27, 2020
ee7
added a commit
to ee7/exercism-configlet
that referenced
this pull request
Jan 21, 2021
Refactor(cli): Reduce duplication Motivations: - We don't need separate `parseMode` and `parseVerbosity` functions - we can just have a generic `parseValue` proc, which is easily extended if we ever add more options that have values. - There should be a single source of truth for the string values of options/values. - This refactoring makes it easier to add support for unambiguous abbreviations of options. - We don't need to specify all the short options, just the short options that we don't want to have.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To-domasterThis PR reduces the code duplication in
cli.nim.The commits are atomic - please review individually. But they can be squashed before merging, if we prefer, given that they work towards the same goal.
Motivations:
parseModeandparseVerbosityfunctions -we can just have a generic
parseValueproc, which is easilyextended if we ever add more options that have values.
options/values.
abbreviations of options.
that we don't want to have.