Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: allow empty exercises.concept[].concepts #272

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

ee7
Copy link
Member

@ee7 ee7 commented Apr 9, 2021

Before this commit, configlet lint would incorrectly exit with a
non-zero exit code if it saw an empty exercises.concept[].concepts
array, even if the corresponding exercises.concept[].status key had
the value deprecated.

Let's use the same temporary workaround for all these arrays, and fix
them all together:

  • exercises.concept[].concepts
  • exercises.concept[].prerequisites
  • exercises.practice[].practices
  • exercises.practice[].prerequisites

This commit is a hotfix for the Elixir track CI due to:


This PR produces the following diff to the configlet lint output:

elixir

-The `exercises.concept.concepts` array is empty:
-./config.json
-
-Configlet detected at least one problem.
-For more information on resolving the problems, please see the documentation:
-https://github.com/exercism/docs/blob/main/building/configlet/lint.md

ruby

-The `exercises.concept.concepts` array is empty:
-./config.json
-
-The `exercises.concept.concepts` array is empty:
-./config.json
-

@ee7 ee7 requested a review from ErikSchierboom as a code owner April 9, 2021 08:13
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the super quick fix!

@ee7 ee7 merged commit 4ca88c8 into exercism:main Apr 9, 2021
@ee7 ee7 deleted the lint-exercises-concept-concepts-allow-empty branch April 9, 2021 08:26
This was referenced Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants