Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmt: operate on every kind of JSON file on a track #478

Open
3 of 5 tasks
ee7 opened this issue Dec 15, 2021 · 2 comments
Open
3 of 5 tasks

fmt: operate on every kind of JSON file on a track #478

ee7 opened this issue Dec 15, 2021 · 2 comments
Labels
kind: feature User-facing enhancement priority: high More important

Comments

@ee7
Copy link
Member

ee7 commented Dec 15, 2021

configlet fmt currently only operates on Concept Exercise and Practice Exercise .meta/config.json files.

It should also operate on the other JSON files:

  • Approach config.json files
  • Article config.json files
  • The track config.json file
  • Concept .meta/config.json files
  • Concept links.json files
@ee7 ee7 added the kind: feature User-facing enhancement label Dec 15, 2021
@ee7
Copy link
Member Author

ee7 commented Dec 16, 2021

When fmt learns to format concept .meta/config.json files, I think we'll need to decide between:

  • Adding a --concept option
  • Renaming the fmt command's --exercise option to --slug, which can then be used for formatting an exercise or a concept (although this is probably bad if a concept can have the same name as an exercise).

We can also consider wheter configlet fmt should eventually grow some scoping options like sync, e.g.:

  • --track
  • --exercises
  • --concepts

With the default of operating on all of them, as sync does.

@ErikSchierboom
Copy link
Member

I'll take a look at this

@ee7 ee7 added the priority: high More important label Dec 15, 2022
ee7 pushed a commit that referenced this issue Oct 5, 2023
And add integration tests for `fmt`.

Refs: #478
Closes: #479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: feature User-facing enhancement priority: high More important
Projects
Status: No status
Development

No branches or pull requests

2 participants