Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hamming: Sync tests #796

Merged
merged 4 commits into from
Jan 22, 2025
Merged

hamming: Sync tests #796

merged 4 commits into from
Jan 22, 2025

Conversation

tasxatzial
Copy link
Member

The current tests were returning nil for strands of unequal length. Admittedly, nil is one of the trickiest parts of the language, but this looks like an incorrect use of nil to me. I've replaced them with Exceptions but will revert if there's any disagreement.

Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think an exception makes more sense

@tasxatzial tasxatzial merged commit 74904a5 into exercism:main Jan 22, 2025
5 checks passed
@tasxatzial tasxatzial deleted the hamming-sync branch January 22, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants