Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to Luhn tests #159

Closed
IanWhitney opened this issue Jan 11, 2017 · 1 comment · Fixed by #160
Closed

Changes to Luhn tests #159

IanWhitney opened this issue Jan 11, 2017 · 1 comment · Fixed by #160

Comments

@IanWhitney
Copy link

We recently rewrote the test suite for the Luhn exercise. Since this track implements Luhn, please take a look at the new canonical_data.json file and see if your track should update its implementation or tests.

Details on the test changes and the motivation can be found in the PR.

Tracking of these changes is being done at the tracking issue.
haus added a commit to haus/xclojure that referenced this issue Feb 19, 2017
@haus
Issue exercism#159: Update luhn test and implementation
93271c7 
Changes to x-common updated the tests and description for luhn to only
test the validity check and not test addends or check digit generation.
This commit adds a test generator for the luhn exercise and updates the
example solution to pass the updated tests. In moving to use the
canonical test data, the inputs to luhn are now strings, so the example
solution was also updated to take that into account.
@haus haus mentioned this issue Feb 19, 2017
Merged
@haus
Copy link
Contributor

haus commented Feb 25, 2017

I opened #160 which I think will resolve this issue.

@haus haus closed this as completed in #160 Feb 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update luhn and add luhn test template haus/xclojure
2 participants
@IanWhitney @haus