Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons for key features #675

Merged
merged 1 commit into from
Jul 31, 2021
Merged

Conversation

ee7
Copy link
Member

@ee7 ee7 commented Jul 28, 2021

The icons for key features are now available, and configlet lint now requires that each key feature has a valid icon value.

This PR sets an initial icon for each key feature - feel free to change them however you want. You can see the list of available icons here. Note that an icon can be used regardless of its name.

With the initial state of this PR, the key features look something like the below.


cross-platform Cross-platform
C is portable and can run on almost any platform and chipset.

general-purpose General purpose
C can be used for a wide variety of workloads from IoT to game engines.

fast Performant
C has been consistently rated as one of the highest performing languages for energy and time.

stable Stable
The C standard values stability and backwards compatibility, C programs can run for decades.

powerful Powerful
C allows both lower and higher level functionality, making it very powerful.

fast Efficient
C allows swift implementation using constructs that map efficiently to machine instructions.

@wolf99
Copy link
Contributor

wolf99 commented Jul 28, 2021

The change looks good to me.

Though maybe the double use of the fast icon indicates that we could rethink the efficient feature. Either to reword to align a little with another icon, or to replace it with a different feature (maybe portable or embeddable).

If replacement is agreed then the efficient content text could be added into the fast content text so as not to lose that aspect completely.

What do you think?

@ee7
Copy link
Member Author

ee7 commented Jul 30, 2021

Though maybe the double use of the fast icon indicates that we could rethink the efficient feature.

I agree. I couldn't see how to avoid the duplicate icon here.

or to replace it with a different feature (maybe portable or embeddable).

I lean towards this. But perhaps portable overlaps too much with the existing "Cross-platform" wording?

I guess widely-used is possible too. Maybe just look at key features on other tracks and steal one that fits?

If you're okay with the icons otherwise - should we just merge this PR, and then you can follow-up however you want?

@ryanplusplus ryanplusplus merged commit 306f1f5 into exercism:main Jul 31, 2021
@ee7 ee7 deleted the key-features-icons branch July 31, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants