Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncx #650

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Syncx #650

merged 2 commits into from
Jan 3, 2024

Conversation

glennj
Copy link
Contributor

@glennj glennj commented Jan 2, 2024

None of the updated tests required any changes to the bats files.

@glennj glennj added the x:rep/small Small amount of reputation label Jan 2, 2024
@glennj glennj requested a review from a team January 2, 2024 15:38
Copy link
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with only one non-blocking question.


You are also able to answer whether the queens can attack each other.
In this case, that answer would be yes, they can, because both pieces share a diagonal.

## Credit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be plural?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily: "credit where credit is due"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is an example wording where it iterates individually, though, as I understand the language. The credits are shown at the end of the movie as a collection, such as we do here.

Either way, I think it is a non-blocker.

@glennj glennj merged commit f7f477b into exercism:main Jan 3, 2024
2 checks passed
@glennj glennj deleted the syncx branch January 5, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:rep/small Small amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants