Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #637: pass actual newlines to the exercise script, not literal '\n' strings #638

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

filbo
Copy link
Contributor

@filbo filbo commented Sep 7, 2023

Not much to say, just run the actual test which was intended...

pull request template


Reviewer Resources:

Track Policies

@glennj glennj linked an issue Sep 7, 2023 that may be closed by this pull request
@glennj glennj added the x:rep/small Small amount of reputation label Sep 7, 2023
Copy link
Contributor

@glennj glennj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@glennj glennj merged commit 58374ad into exercism:main Sep 7, 2023
2 checks passed
@filbo
Copy link
Contributor Author

filbo commented Sep 8, 2023

Thanks, @glennj ...

I noticed that #637, the bug report, showed up on my exercism.com/journey/reputation as a 'Building Exercism' kudo; but #638, the PR, did not. I'm not complaining, just curious what rules are being followed by the system, and the thoughts behind them. (There is probably a web link which would immediately answer this...)

@IsaacG
Copy link
Member

IsaacG commented Sep 8, 2023

@filbo See https://exercism.org/docs/using/product/reputation and https://exercism.org/docs/building

I believe "building" means "contributing to the exercises in some way" even if that "way" is a tweak to a test input.

@glennj
Copy link
Contributor

glennj commented Sep 8, 2023

In your reputation, you should see You created PR#638 on bash: Fix #637: pass actual newlines to the exercise script, not literal '\n' strings with 5 reputation points.

My own reputaton journey contains
image

@filbo
Copy link
Contributor Author

filbo commented Sep 10, 2023

Yeah, my mistake, it was #638-the-PR which showed up and #637-the-bug which didn't generate any credit. Which was mildly surprising, but I see now in the guide that only major issue reports get credit. That's fine, I just needed to find the info to de-puzzle myself :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:rep/small Small amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Word Count' test 'handles expanded lists' is mis-executed
3 participants