This repository has been archived by the owner on Aug 1, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. x-common issue #95.
I've expanded the JS test for the 'binary' exercise to include the same examples as the Ruby equivalent. The example solution has also been updated so it passes the new tests.
However, I'm not familiar enough with the Exercism progression to know if this is pitched at an appropriate level – that is, if students are expected to do string validation or understand the nuances of
parseInt
at this point. JavaScript'sparseInt
is rather more flexible than solutions in other languages, and doesn't make it easy to bail out on invalid input:If there's a different approach you'd like me to take with this, let me know and I'll adjust this PR to suit. :)