Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying custom check icon svg #203

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Allow specifying custom check icon svg #203

wants to merge 3 commits into from

Conversation

sealphie
Copy link

Allows custom svg image for check button by specifying checkbutton_image_svg.

@welcome
Copy link

welcome bot commented Feb 25, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

choldgraf
choldgraf reviewed Feb 25, 2023
View reviewed changes
Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two quick comments - thanks

sphinx_copybutton/__init__.py Outdated Show resolved Hide resolved
sphinx_copybutton/_static/copybutton.js_t Show resolved Hide resolved
@choldgraf
Copy link
Member

Hmm I do not see any copy buttons in the built docs:

https://sphinx-copybutton--203.org.readthedocs.build/en/203/

Could you confirm that the JS is correct?

@sealphie
Copy link
Author

Hmm I do not see any copy buttons in the built docs:

https://sphinx-copybutton--203.org.readthedocs.build/en/203/

Could you confirm that the JS is correct?

Hey, sorry I didn't see this issue due to local browser cache. Should be fixed for now.

@stefanodavid
Copy link
Contributor

hi @choldgraf, this functionality seems quite useful (well, at least for me!), is there a reason why this PR hasn't yet merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choldgraf choldgraf Awaiting requested review from choldgraf

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sealphie @choldgraf @stefanodavid