Make article width take up whole page in absence of secondary sidebar

[flying-sheep]

Fixes #736

before:
after:

[welcome]

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

[choldgraf]

Thanks for this improvement - could you please explain the rationale behind the fix? I believe that it works, but I don't understand why setting a max width will improve the case where the content was too narrow. How does a maximum width cause a shrunken container to grow?! Is this some kind of CSS quirk?

[flying-sheep]

Before my change, _article.scss contained the flex-grow: 0 hack. The hack was there so the absence of a sidebar doesn’t result in a super wide content area, but it had the side effect of making the content area collapse to a super narrow width in that case.

Removing that hack makes it flex-grow: 1 again, so it will grow to fill more than the absolute minimum horizontal space. I then added max-width for making it not take any more space than it should and justify-content: left for not moving to the right (i.e. not centering itself in the space reserved for content and sidebar). Those three changes replace the hack with a more robust solution.

[welcome]

Congrats on your first merged pull request in this project! 🎉


Thank you for contributing, we are very proud of you! ❤️

[choldgraf]

this is really helpful context, thanks for sharing!