👌 IMPROVE: Fail gracefully on non-dict front-matter (#409)

executablebooks · Aug 6, 2021 · 61f1154 · 61f1154
1 parent 5fd4c51
commit 61f1154
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/myst_parser/docutils_renderer.py b/myst_parser/docutils_renderer.py
@@ -609,7 +609,12 @@ def render_front_matter(self, token: SyntaxTreeNode) -> None:
         if not isinstance(token.content, dict):
             try:
                 data = yaml.safe_load(token.content)
-            except (yaml.parser.ParserError, yaml.scanner.ScannerError) as error:
+                assert isinstance(data, dict), "not dict"
+            except (
+                AssertionError,
+                yaml.parser.ParserError,
+                yaml.scanner.ScannerError,
+            ) as error:
                 msg_node = self.reporter.error(
                     "Front matter block:\n" + str(error), line=position
                 )

diff --git a/myst_parser/sphinx_renderer.py b/myst_parser/sphinx_renderer.py
@@ -192,7 +192,11 @@ class MockSphinx(Sphinx):
         def __init__(self, confoverrides=None, srcdir=None, raise_on_warning=False):
             self.extensions = {}
             self.registry = SphinxComponentRegistry()
-            self.html_themes = {}
+            try:
+                self.html_themes = {}
+            except AttributeError:
+                # changed to property in sphinx 4.1
+                pass
             self.events = EventManager(self)
 
             # logging