-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: test wider matrix #552
Conversation
a9bea3b
to
463e999
Compare
Let me cut down the number of jobs, slightly. |
e14ea90
to
4812d8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 - the changes LGTM though note there are some failing tests. I hit approve and leave it to your judgment whether it's right to merge
Would
instead of the current
mitigate the error, @agoose77? Curious that it fails only for some of the tests from the matrix. |
updates: - [github.com/astral-sh/ruff-pre-commit: v0.0.291 → v0.0.292](astral-sh/ruff-pre-commit@v0.0.291...v0.0.292) - [github.com/pre-commit/mirrors-mypy: v1.5.1 → v1.6.0](pre-commit/mirrors-mypy@v1.5.1...v1.6.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Angus Hollands <[email protected]>
updates: - [github.com/psf/black: 23.9.1 → 23.10.0](psf/black@23.9.1...23.10.0) - [github.com/astral-sh/ruff-pre-commit: v0.0.292 → v0.1.1](astral-sh/ruff-pre-commit@v0.0.292...v0.1.1) - [github.com/pre-commit/mirrors-mypy: v1.6.0 → v1.6.1](pre-commit/mirrors-mypy@v1.6.0...v1.6.1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
788fdb8
to
c4030ac
Compare
Relevant line from the readthedocs build:
|
This is the fix that I've ultimately chosen, thanks @michaelweinold — I was also thinking of using a non-escaped character. I wasn't sure why docutils fails to escape this properly before I realised that it's being escaped in JSON, not in Python. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
Well, well, well - the tests look great! Glad I could help with #552 (comment). Could we get another review by @choldgraf, perhaps? I believe everyone in #543 is eager for a new release. |
This PR updates our CI to check Python 3.12, and varies
myst-parser