Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop documentation build raising Exception if code cells raise Exceptions #393

Closed

Conversation

rdbisme
Copy link

@rdbisme rdbisme commented Feb 11, 2022

See #392

@welcome
Copy link

welcome bot commented Feb 11, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@rdbisme rdbisme force-pushed the raise-if-execution-fails branch from c9126c2 to d5012f4 Compare February 11, 2022 18:20
@chrisjsewell
Copy link
Member

Hey @rdbisme thanks for the PR. I am just finishing #380 though, which is a big change of the execution code, so if it's ok, I will look to add this to that

@rdbisme rdbisme force-pushed the raise-if-execution-fails branch from d5012f4 to cffefa2 Compare February 12, 2022 12:00
@rdbisme
Copy link
Author

rdbisme commented Feb 12, 2022

Hey @rdbisme thanks for the PR. I am just finishing #380 though, which is a big change of the execution code, so if it's ok, I will look to add this to that

No problem. The only matter of discussion here I think is if this needs an additional config option or execution_allow_errors is a good choice.

if `execution_allow_errors` is False
@rdbisme rdbisme force-pushed the raise-if-execution-fails branch from c52a690 to 95ff5b8 Compare February 12, 2022 22:18
@codecov
Copy link

codecov bot commented Feb 12, 2022

Codecov Report

Merging #393 (30fa482) into master (52f7fb7) will decrease coverage by 0.16%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
- Coverage   87.35%   87.19%   -0.17%     
==========================================
  Files          12       12              
  Lines        1368     1374       +6     
==========================================
+ Hits         1195     1198       +3     
- Misses        173      176       +3     
Flag Coverage Δ
pytests 87.19% <77.77%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
myst_nb/execution.py 81.20% <77.77%> (-1.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52f7fb7...30fa482. Read the comment docs.

@chrisjsewell
Copy link
Member

Closing this for now (see my comment #392 (comment))
Can always re-open later if required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants