[a11y] Allow button to be focused and toggle dropdown with space/enter. #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drnic
commented
Jan 24, 2021
drnic
force-pushed
the
a11y-aria-focus
branch
from
f02256e to
805c3d9
Compare
drnic
changed the title
drnic
force-pushed
the
a11y-aria-focus
branch
from
ee8e289 to
805c3d9
Compare
drnic
changed the title
|
Great job on this @drnic! Definitely need to pay closer attention to a11y. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can also focus on the dropdown button if
tabindex="0"is included.They can toggle the dropdown with Space or Enter if the attribute
data-dropdown-target="button"is included on the button.Demo video of the feature and DOM changes https://share.getcloudapp.com/wbu9jn1G
I have tested this manually against the docs/index.html app locally. I tried shipping the built
dist/in the PR to make the demo work but it didn't. Not sure what's going on there. So this PR is just the change, but notdist/.