Safely handle when database or table doesn't exist

excid3 · Mar 13, 2021 · 0cfcebe · 0cfcebe
1 parent 816ea44
commit 0cfcebe
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 ### Unreleased
 
+# 1.3.1
+
+* Safely handle choosing coder when database or table doesn't exist - @excid3
+
 # 1.3.0
 
 * Add `has_noticed_notifications` helper for models - @excid3

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -11,7 +11,7 @@ GIT
 PATH
   remote: .
   specs:
-    noticed (1.3.0)
+    noticed (1.3.1)
       http (>= 4.0.0)
       rails (>= 6.0.0)
 

diff --git a/gemfiles/rails_6.gemfile.lock b/gemfiles/rails_6.gemfile.lock
@@ -11,7 +11,7 @@ GIT
 PATH
   remote: ..
   specs:
-    noticed (1.3.0)
+    noticed (1.3.1)
       http (>= 4.0.0)
       rails (>= 6.0.0)
 

diff --git a/gemfiles/rails_6_1.gemfile.lock b/gemfiles/rails_6_1.gemfile.lock
@@ -11,7 +11,7 @@ GIT
 PATH
   remote: ..
   specs:
-    noticed (1.3.0)
+    noticed (1.3.1)
       http (>= 4.0.0)
       rails (>= 6.0.0)
 

diff --git a/gemfiles/rails_master.gemfile.lock b/gemfiles/rails_master.gemfile.lock
@@ -97,7 +97,7 @@ GIT
 PATH
   remote: ..
   specs:
-    noticed (1.3.0)
+    noticed (1.3.1)
       http (>= 4.0.0)
       rails (>= 6.0.0)
 

diff --git a/lib/noticed/model.rb b/lib/noticed/model.rb
@@ -24,12 +24,16 @@ def mark_as_unread!
       end
 
       def noticed_coder
+        return Noticed::TextCoder unless table_exists?
+
         case attribute_types["params"].type
         when :json, :jsonb
           Noticed::Coder
         else
           Noticed::TextCoder
         end
+      rescue ActiveRecord::NoDatabaseError
+        Noticed::TextCoder
       end
     end
 

diff --git a/lib/noticed/version.rb b/lib/noticed/version.rb
@@ -1,3 +1,3 @@
 module Noticed
-  VERSION = "1.3.0"
+  VERSION = "1.3.1"
 end