Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix styleOption error in index.ts #1358

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Fix styleOption error in index.ts #1358

merged 1 commit into from
Jun 30, 2020

Conversation

sdg9670
Copy link
Contributor

@sdg9670 sdg9670 commented Jun 29, 2020 •
edited
Loading

Summary

#1357

Fix styleOption error in index.ts

As typescript updates, errors occur where existing styleOption is omitted.

image

@Subhajitdas298
Copy link
Contributor

Thanks for the fix. Sorry, I missed the optional identifier.

@Subhajitdas298 Subhajitdas298 mentioned this pull request Jun 30, 2020
Closed
@Subhajitdas298
Copy link
Contributor

@alubbe Please merge this, as it fixes missing optional operator for type script users.

@alubbe alubbe merged commit 29467df into exceljs:master Jun 30, 2020
@Subhajitdas298 Subhajitdas298 mentioned this pull request Jul 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alubbe alubbe alubbe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdg9670 @Subhajitdas298 @alubbe