Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import syntax docs #701

Merged
merged 2 commits into from
Nov 30, 2016
Merged

Add import syntax docs #701

merged 2 commits into from
Nov 30, 2016

Conversation

kamranayub
Copy link
Member

Added #675 info to official docs to help assist people in referencing Ex via import syntax until #606 is done

@kamranayub kamranayub added the docs Relating to documentation in any way label Nov 30, 2016
@kamranayub kamranayub added this to the 0.8.0 Release milestone Nov 30, 2016

.. code-block:: typescript

import { ex } from 'excalibur'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will work...

.. code-block:: typescript

export = ex;
export as namespace ex;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need the 2nd export

Copy link
Member

@eonarheim eonarheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast fix! 🚀

@eonarheim eonarheim merged commit 0574077 into master Nov 30, 2016
@eonarheim eonarheim deleted the docs-import-syntax branch November 30, 2016 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Relating to documentation in any way
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants