Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Closes #60] Streamline and fix Actor world coordinates #620

Merged
merged 7 commits into from
Aug 13, 2016

Conversation

kamranayub
Copy link
Member

@kamranayub kamranayub commented Aug 4, 2016

Closes #60

This is a change that should fix problems we've been having with children and grandchildren drawing correctly but reporting incorrect world coordinates.

Due to this fix, I also uncovered #618 and fixed that issue as well (see #619)

Here is the visual test that confirms that children and grandchildren can be scaled + rotated and report correct world coords:

image

Proposed Changes:

  • Add getWorldPos method off Actor
  • Take into account Actor graph when calculating scale and rotation
  • Add unit and visual tests to confirm reality

@kamranayub kamranayub added the bug This issue describes undesirable, incorrect, or unexpected behavior label Aug 4, 2016
@kamranayub kamranayub added this to the 0.7.0 Release milestone Aug 4, 2016
@kamranayub
Copy link
Member Author

This is ready to merge when you are.

@eonarheim
Copy link
Member

I added the visual test to the list of visual tests

@eonarheim eonarheim merged commit 1ec4a8e into master Aug 13, 2016
@kamranayub kamranayub deleted the 60-actor-coords branch August 19, 2016 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need a better way to keep track of local and global coordinates for actors
2 participants