Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make RotateTo+RotationType functionality more available #3291

Merged
merged 19 commits into from
Dec 9, 2024
Merged

feat: Make RotateTo+RotationType functionality more available #3291

merged 19 commits into from
Dec 9, 2024

Conversation

isokissa
Copy link
Contributor

@isokissa isokissa commented Nov 29, 2024 •
edited
Loading

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #3288

Changes:

  • Introduced angleBetween metdhod to Vector class.
  • fixed canonicalizeAngle to never return 2PI
  • RotationType moved to Math
  • small documentation improvements
  • added/modified tests to Vector.rotate() to illustrate the conventions

isokissa and others added 14 commits November 29, 2024 15:33
@isokissa
Move RotationType to Math package
310cd12 
This way we remove the circular dependency between Actions and Math packages.
@isokissa
Hide Actions.RotationType
31b4c9d
@isokissa
WIP Borow implementation from lerpAngle
f3b8b3b 
Work in progress. Also the seed of unit test.
@isokissa
Verify that positive rotation is clockwise
00d6833
@isokissa
Correct tests, make them more readable too
c01e87e
@isokissa
RemoveRotation type from Actions package
fc7e53c 
For Excalibur users, the change is backwards compatible, because
RemoveRotation is a global symbol within Excalibur pacakge. All
internal uses are modified to use RemoveRotation from Math package.
@petar-jr
Merge branch 'main' into feature/add-angledifference
aac8200
@petar-jr
Use the current version of docker compose
660436e
@petar-jr
Merge branch 'main' into feature/add-angledifference
bf493c5
@petar-jr
Add more documentation
9ee8915
@petar-jr
Canonicalized angle does not include 2PI
07db95b
@petar-jr
Import RotationType from correct place
5b73439
@petar-jr
Add angleBetween implementation and unit tests
8e96f5e
@petar-jr
Update Changelog
7f05ef7
@isokissa isokissa marked this pull request as ready for review December 2, 2024 23:43
@isokissa
Copy link
Contributor Author

isokissa commented Dec 3, 2024

@eonarheim this is ready, waiting for your review and blessing :) Locally all tests pass, don't know how to trigger the check here on github.

@eonarheim
Copy link
Member

@isokissa Apologies I've been busy with other things, I'll give this a proper look today

@isokissa
Copy link
Contributor Author

isokissa commented Dec 3, 2024

Still stying problems in vector.ts, but it won't tell me what is wrong.

And yeah, I ended up not using lerpAngle's logic, I wrote angleBetween a bit simpler, IMHO.

@isokissa
Copy link
Contributor Author

isokissa commented Dec 8, 2024

Fixed formatting, now it should be 100% ready for review. @eonarheim

@eonarheim eonarheim merged commit 5ecb464 into excaliburjs:main Dec 9, 2024
3 checks passed
@eonarheim
Copy link
Member

@isokissa Thanks a ton! This is a great addition, much appreciated!

@isokissa isokissa deleted the feature/add-angledifference branch December 9, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make RotateTo+RotationType functionality more available
3 participants
@isokissa @eonarheim @petar-jr