Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Use geometry instancing in new ImageRendererV2 #3278

Merged
merged 15 commits into from
Nov 29, 2024

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Nov 16, 2024

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

This PR roughly doubles the performance in ex.ImageRendererV2 over ex.ImageRenderer.

TODO:

  • Flag for v0.30 to fallback to the old one if needed
  • Text not rendering properly yet
  • Snap to pixel
  • Tests

Copy link

cloudflare-workers-and-pages bot commented Nov 16, 2024

Deploying excaliburjs with  Cloudflare Pages  Cloudflare Pages

Latest commit: f619452
Status: ✅  Deploy successful!
Preview URL: https://20250df7.excaliburjs.pages.dev
Branch Preview URL: https://perf-instancing-experiment.excaliburjs.pages.dev

View logs

@eonarheim eonarheim merged commit f3a9cda into main Nov 29, 2024
7 of 8 checks passed
@eonarheim eonarheim deleted the perf/instancing-experiment branch November 29, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant