Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Gif parsing did not work with certain formats #3173

Merged
merged 8 commits into from
Aug 9, 2024
Merged

fix: Gif parsing did not work with certain formats #3173

merged 8 commits into from
Aug 9, 2024

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Aug 9, 2024 •
edited
Loading

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #3172

This PR fixes GIF parsing for certain gif formats. Leverages the documentation provided by GIFLib https://giflib.sourceforge.net/whatsinagif/index.html

Changes:

  • Tweak the image generation algorithm to be more efficient
  • Support Local Color Table in image generation
  • Support Disposal Method to allow frame to frame persistence

@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label Aug 9, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Aug 9, 2024 •
edited
Loading

Deploying excaliburjs with  Cloudflare Pages  Cloudflare Pages

Latest commit: aeffede
Status: ✅  Deploy successful!
Preview URL: https://4f4a5c8e.excaliburjs.pages.dev
Branch Preview URL: https://fix-gif-parsing.excaliburjs.pages.dev

View logs

@eonarheim eonarheim merged commit 0d6ea12 into main Aug 9, 2024
7 of 8 checks passed
@eonarheim eonarheim deleted the fix/gif-parsing branch August 9, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix GIF parsing for certain gif formats
1 participant
@eonarheim