Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement Collision Sub-Stepping #3136

Merged
merged 5 commits into from
Jul 23, 2024
Merged

feat: Implement Collision Sub-Stepping #3136

merged 5 commits into from
Jul 23, 2024

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Jul 23, 2024 •
edited
Loading

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Related to #3135

Changes:

  • Adds collision sub-stepping to discretize each frame further to help with fast moving objects
  • Improves integration accuracy

@github-actions github-actions bot added the enhancement Label applied to enhancements or improvements to existing features label Jul 23, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jul 23, 2024 •
edited
Loading

Deploying excaliburjs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5a45e3f
Status: ✅  Deploy successful!
Preview URL: https://03bc5b84.excaliburjs.pages.dev
Branch Preview URL: https://feat-collision-sub-stepping.excaliburjs.pages.dev

View logs

@eonarheim
Copy link
Member Author

@kfalicov I've found that 4-5 substeps does a pretty good job in your example.

I'll be trying out speculative contacts CCD in another PR

@eonarheim eonarheim merged commit a503de4 into main Jul 23, 2024
7 of 8 checks passed
@eonarheim eonarheim deleted the feat/collision-sub-stepping branch July 23, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Label applied to enhancements or improvements to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eonarheim