Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [#1733][#1734] New FullScreen and Dynamic DisplayModes #1735

Merged
merged 3 commits into from
Jan 1, 2021

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Dec 22, 2020

fullscreen

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #1733
Closes #1734

Changes:

  • Breaking change: DisplayMode.FullScreen will now scale the game to fit the available space, preserving the aspectRatio. This matches the browser "FullScreen" api behavior
  • New: DisplayMode.Dynamic now does what DisplayMode.FullScreen used to do, the resolution and viewport dynamically adjust to fit the available space, DOES NOT preserve aspectRatio
  • Fix: In the the browser "FullScreen" api, coordinates are now correctly mapped from page space to world space
  • Added: Screen helpers for mapping between world, screen, and page space coordinates
  • Deprecate: DisplayMode.Position CSS can accomplish this task better than Excalibur
  • Tests!

@github-actions github-actions bot added enhancement Label applied to enhancements or improvements to existing features feature Label applied to new feature requests labels Dec 22, 2020
@eonarheim eonarheim merged commit 33325af into main Jan 1, 2021
@eonarheim eonarheim deleted the feature/dynamic-fullscreen-displaymode branch January 1, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Label applied to enhancements or improvements to existing features feature Label applied to new feature requests
Projects
None yet
1 participant