Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#1417] [#1431] Loader positioning, allow customization, clean-up html #1507

Merged
merged 8 commits into from
May 23, 2020
Merged

fix: [#1417] [#1431] Loader positioning, allow customization, clean-up html #1507

merged 8 commits into from
May 23, 2020

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Apr 26, 2020 •
edited
Loading

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #1417
Closes #1431

Changes:

  • Adds an id to the play button root element #excalibur-play-root
  • Allows modification of all loader positioned elements
    • Logo
    • Play button
    • Loading bar
  • Additionally allows the loading bar color to be set

Sorry, something went wrong.

@eonarheim
First pass at updating loader
75df8cd 
* Add id to play button root element
* Make positioning and colors flexible of all things on screen
* Needs tests
@eonarheim
Add some baseline tests, more needed
fd1d594
@jedeen jedeen added the work-in-progress A work in progress pull request, will not be merged until this is removed label Apr 26, 2020
@jedeen jedeen marked this pull request as draft May 11, 2020 15:53
@eonarheim eonarheim removed the work-in-progress A work in progress pull request, will not be merged until this is removed label May 14, 2020
@eonarheim eonarheim marked this pull request as ready for review May 14, 2020 00:42
@eonarheim eonarheim requested review from kamranayub and jedeen May 14, 2020 00:42
@eonarheim eonarheim changed the title [#1417] Fix loader positioning, allow customization fix: [#1417] Loader positioning, allow customization May 16, 2020
@eonarheim
Copy link
Member Author

@kamranayub @jedeen Planning to merge this today if no objections

@kamranayub
Copy link
Member

Think you'd be willing to fix #1431 too 😄

@eonarheim
Copy link
Member Author

Haha sure, I'll roll in #1431 @kamranayub

@kamranayub kamranayub added enhancement Label applied to enhancements or improvements to existing features fix labels May 20, 2020
@eonarheim
Copy link
Member Author

@kamranayub all fixed up 👍

kamranayub
kamranayub approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@kamranayub kamranayub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@eonarheim eonarheim changed the title fix: [#1417] Loader positioning, allow customization fix: [#1417] [#1431] Loader positioning, allow customization, clean-up html May 23, 2020
@eonarheim eonarheim merged commit c5d710a into master May 23, 2020
@eonarheim eonarheim deleted the bugfix/1417-fix-loader-positioning branch May 23, 2020 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamranayub kamranayub

@jedeen jedeen

Assignees
No one assigned
Labels
enhancement Label applied to enhancements or improvements to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Play button position cannot be set with CSS
3 participants
@eonarheim @kamranayub @jedeen