Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1345] Fix typing on pointer event handlers #1347

Merged
merged 4 commits into from
Dec 3, 2019

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Dec 2, 2019

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #1345

Changes:

  • Add's strong type signatures to the Pointer type for on(...), once(...), and off(..) handlers

@eonarheim eonarheim merged commit ef068f3 into master Dec 3, 2019
@eonarheim eonarheim deleted the bugfix/1345-strongly-typed-pointer branch December 3, 2019 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

class Pointer does not have class Pointers events
1 participant