Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CollisionGroups do not work at all #862

Closed
eonarheim opened this issue Aug 12, 2017 · 4 comments · Fixed by #1131
Closed

CollisionGroups do not work at all #862

eonarheim opened this issue Aug 12, 2017 · 4 comments · Fixed by #1131
Assignees
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior core team This issue should be done by an Excalibur core member

Comments

@eonarheim
Copy link
Member

Steps to Reproduce

The .onCollidesWith handler does not fire when active collision types collide with groups added with .addCollisionGroup that match the filter in the handler.

Here is a codepen reproducing the issue https://codepen.io/eonarheim/pen/LjjeEm
Left click to move the read block right, right click to move the blue block left.

We also have a second "Group" type that is confusing on which should be used.

Expected Result

What should happen is that a message should be written if the blocks collide since there is a collision group handler on actor1.

Actual Result

As far as I can tell this does not happen, possibly a regression during the collision system over-haul.

@eonarheim eonarheim added the bug This issue describes undesirable, incorrect, or unexpected behavior label Aug 12, 2017
@eonarheim eonarheim added this to the 0.12.0 Release milestone Aug 12, 2017
@eonarheim eonarheim self-assigned this Aug 12, 2017
@eonarheim
Copy link
Member Author

In fact upon further review they seem to be half implemented... perhaps this was a leftover from a hopeful implemenation or from the Groups implementation?

@jedeen jedeen modified the milestones: 0.12.0 Release, 0.13.0 Release Aug 12, 2017
@eonarheim
Copy link
Member Author

This is an interesting read and may be pertinent to this issue http://www.aurelienribon.com/blog/2011/07/box2d-tutorial-collision-filtering/

@jedeen jedeen modified the milestones: 0.13.0 Release, Child Actors + Groups Oct 3, 2017
@moonblade
Copy link

Is there any updates on this issue?

@eonarheim
Copy link
Member Author

@moonblade None yet, we intend to redesign the way collision groups work. We are definitely open to suggestions/ideas on what you'd like to see in a feature like this.

@eonarheim eonarheim added the core team This issue should be done by an Excalibur core member label Jan 24, 2019
eonarheim added a commit that referenced this issue Jun 8, 2019
Closes #1091
Closes #862

## Changes:

- Implement collision group proposal in #1091
- Wire into collider infrastructure
- Add unit tests 
- Update visual tests

![blocks](https://user-images.githubusercontent.com/612071/56842198-c8fdd580-6858-11e9-9dab-b9dbda132ea7.gif)
@jedeen jedeen modified the milestones: groups, child actors, 0.23.0 Release Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior core team This issue should be done by an Excalibur core member
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants