Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Children are not being updated by their parent actors #616

Closed
kamranayub opened this issue Aug 3, 2016 · 1 comment
Closed
Assignees
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Milestone

Comments

@kamranayub
Copy link
Member

kamranayub commented Aug 3, 2016

Steps to Reproduce

  1. Create an Actor
  2. Create another Actor
  3. Add the second actor to the first
  4. Add logic to the second actor's update method
  5. Verify when game starts that the logic in the second actor's update is never called

Expected Result

Children actors should participate in the update loop. This is a regression.

Actual Result

Child actor's update is never called

Proposed Changes

Add this to the end of Actor.update:

// Update child actors
for (var i = 0; i < this.children.length; i++) {          
  this.children[i].update(engine, delta);          
}
@kamranayub kamranayub added the bug This issue describes undesirable, incorrect, or unexpected behavior label Aug 3, 2016
@kamranayub kamranayub added this to the 0.7.0 Release milestone Aug 3, 2016
@eonarheim
Copy link
Member

:( mega sad

eonarheim pushed a commit that referenced this issue Aug 4, 2016
* [Closes #616] Child actors should be updated
* Compile dists
* Recompile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Development

No branches or pull requests

2 participants