Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freezeframe is never set to last animation frame #506

Closed
jedeen opened this issue Aug 20, 2015 · 2 comments
Closed

freezeframe is never set to last animation frame #506

jedeen opened this issue Aug 20, 2015 · 2 comments
Assignees
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior good first issue good for people new to open source and Excalibur
Milestone

Comments

@jedeen
Copy link
Member

jedeen commented Aug 20, 2015

door_animation

After the animation plays, the current drawing for that actor disappears. The same behavior occurs for getAnimationForAll(), getAnimationBetween, and getAnimationByIndices(). In fact, it does not appear that freezeframe is ever set other than when it is initialized as '-1'. According to the documentation, the default freezeframe for an animation should be the last frame of the animation.

The current workaround is to manually set the freezeframe for each animation.

@jedeen jedeen added bug This issue describes undesirable, incorrect, or unexpected behavior good first issue good for people new to open source and Excalibur labels Aug 20, 2015
@jedeen jedeen added this to the 0.6 Release milestone Aug 20, 2015
@eonarheim
Copy link
Member

@jedeen Would you always want animations to default to stop on the last frame and freeze frame? I do agree that this does not match the documentation here: http://excaliburjs.com/docs/api/edge/classes/ex.animation.html#freezeframe, but I'm questioning that behavior.

For instance what if you had animations that were explosions or some other special effect and you wanted them to play once and complete with nothing being drawn. Or would you always expect the freeze frame on the last frame and include and empty frame at the end of effect related animations?

@jedeen On that same note, should animations also loop by default as well?

@jedeen
Copy link
Member Author

jedeen commented Aug 21, 2015

@eonarheim I don't think that looping by default is expected behavior. In my opinion, the method we currently have described in the documentation is the most straightforward of our options.

@jedeen jedeen self-assigned this Sep 17, 2015
@jedeen jedeen closed this as completed in 0d3763e Oct 1, 2015
eonarheim added a commit that referenced this issue Oct 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior good first issue good for people new to open source and Excalibur
Projects
None yet
Development

No branches or pull requests

2 participants