Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Timer unpause() method, to be named resume() #1864

Closed
eonarheim opened this issue Apr 30, 2021 · 0 comments · Fixed by #1929
Closed

Refactor Timer unpause() method, to be named resume() #1864

eonarheim opened this issue Apr 30, 2021 · 0 comments · Fixed by #1929

Comments

@eonarheim
Copy link
Member

Context

Currently unpause() is not usually the word used to resume() something that has been paused()

Proposal

Rename unpause() to resume()
eonarheim added a commit that referenced this issue Jun 27, 2021
@eonarheim
fix: [#1864] [#1865] Timer.start() must be called + rename Timer.unpa…
6df7ed1 
…use() -> Timer.resume()
@eonarheim eonarheim mentioned this issue Jun 27, 2021
Merged
5 tasks
eonarheim added a commit that referenced this issue Jun 27, 2021
@eonarheim
fix: [#1864] [#1865] Timer.start() must be called + rename Timer.unpa…
37e1b24 
…use() -> Timer.resume() (#1929)


Closes #1864
Closes #1865

## Changes:

- Adds `Timer.start()` to explicitly start timers, they will no longer implicitly start when added to a scene.
- Adds `Timer.stop()` to stop and "rewind" a timer
- Adds `Timer.timeToNextAction` will return the milliseconds until the next action callback
- Adds `Timer.timeElapsedTowardNextAction` will return the milliseconds counted towards the next action callback
- Renames the `Timer.unpause()` to `Timer.resume()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@eonarheim