Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Scene.onActivate and onDeactivate being called with incorrect arguments #1850

Closed
kamranayub opened this issue Apr 26, 2021 · 1 comment · Fixed by #1930
Closed

Bug: Scene.onActivate and onDeactivate being called with incorrect arguments #1850

kamranayub opened this issue Apr 26, 2021 · 1 comment · Fixed by #1930
Assignees
@kamranayub
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior stale This issue or PR has not had any activity recently
Milestone
0.25.0 Release

Comments

@kamranayub
Copy link
Member

Steps to Reproduce

Call engine.goToScene(scene) and have code inspecting oldScene and newScene in onActivate or onDeactivate methods of Scene.

Expected Result

oldScene and newScene should be single Scene objects

Actual Result

Engine invokes _activate and _deactivate using .call(scene, [oldScene, newScene]) which passes the array as the first argument instead of as 1st and 2nd args.

Either it should be .call(scene, oldScene, newScene) or .apply(scene, [oldScene, newScene])

Current code:

this.currentScene._deactivate.call(this.currentScene, [oldScene, newScene]);

Environment

  • browsers and versions:
  • operating system:
  • Excalibur versions:
  • (anything else that may be relevant)

Current Workaround

Code has to manually force type to be array of scene and handle it in a hacky way.
@kamranayub kamranayub added the bug This issue describes undesirable, incorrect, or unexpected behavior label Apr 26, 2021
@kamranayub kamranayub added this to the 0.25.0 Release milestone Apr 26, 2021
@kamranayub kamranayub self-assigned this Apr 26, 2021
kamranayub added a commit that referenced this issue Apr 26, 2021
@kamranayub
fix(engine): pass scene args correctly, fixes #1850
069e0cb
@github-actions
Copy link

This issue hasn't had any recent activity lately and is being marked as stale automatically.

@github-actions github-actions bot added the stale This issue or PR has not had any activity recently label Jun 26, 2021
eonarheim added a commit that referenced this issue Jun 27, 2021
@eonarheim
fix: [#1850] Fix Scene.onActivate/onDeactivate args
76b9014
@eonarheim eonarheim mentioned this issue Jun 27, 2021
Merged
5 tasks
eonarheim added a commit that referenced this issue Jun 27, 2021
@eonarheim
fix: [#1850] Fix Scene.onActivate/onDeactivate args (#1930)
f784582 
Closes #1850

## Changes:

- Call onActivate/onDeactivate with the correct arguments switch from call -> apply
- Add a test for this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kamranayub kamranayub

Labels
bug This issue describes undesirable, incorrect, or unexpected behavior stale This issue or PR has not had any activity recently
Projects
None yet
Milestone
0.25.0 Release
Development

Successfully merging a pull request may close this issue.

fix: [#1850] Fix Scene.onActivate/onDeactivate args excaliburjs/Excalibur
1 participant
@kamranayub