Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scene onInitialize does not fire before actor onInitialize #1553

Closed
eonarheim opened this issue May 21, 2020 · 0 comments · Fixed by #1554
Closed

Scene onInitialize does not fire before actor onInitialize #1553

eonarheim opened this issue May 21, 2020 · 0 comments · Fixed by #1554
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior

Comments

@eonarheim
Copy link
Member

This bug was discovered and fixed in Ludum 46

Steps to Reproduce

Create a scene and override the onInitialize
Create an actor in that scene and override the onInitialize

Observe that the actor onInitialize fires before the scene's, which is unexpected and not according to the documentation

Expected Result

Scenes must fully initialize before attempting to initialize their actors.

Actual Result

When using the lifecycle onInitialize override the order was not respected

Environment

  • browsers and versions: All
  • operating system: N/A
  • Excalibur versions: master

Current Workaround

None
@eonarheim eonarheim added the bug This issue describes undesirable, incorrect, or unexpected behavior label May 21, 2020
@eonarheim eonarheim mentioned this issue May 21, 2020
Merged
5 tasks
eonarheim added a commit that referenced this issue May 23, 2020
@eonarheim
fix: [#1553] Scene onInitialize order (#1554)
02e1a61 
Closes #1553

## Changes:

- Update the Scene `onInitialize` order
- Add test to confirm order works
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: [#1553] Scene onInitialize order excaliburjs/Excalibur
1 participant
@eonarheim