Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Engine pointer events are not emitted #1439

Closed
kamranayub opened this issue Feb 28, 2020 · 4 comments · Fixed by #1925
Closed

Bug: Engine pointer events are not emitted #1439

kamranayub opened this issue Feb 28, 2020 · 4 comments · Fixed by #1925
Assignees
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior Hacktoberfest Issues marked for the community Hacktoberfest event https://hacktoberfest.digitalocean.com/

Comments

@kamranayub
Copy link
Member

kamranayub commented Feb 28, 2020

I was trying to subscribe to canvas pointer events via engine.input.pointers but it seems that they are no longer being emitted as I would expect

Steps to Reproduce

engine.input.pointers.on('up', () => {
  console.log('pointerup');
});

https://codesandbox.io/s/pedantic-ishizaka-pyjzn

Expected Result

Console log should display when canvas is clicked anywhere

Actual Result

No event is emitted

Environment

  • browsers and versions: Chrome 80
  • operating system: Mac OS
  • Excalibur versions: 0.23.0

Current Workaround

It looks like this is fixed in master currently and should be released in 0.24.0

@kamranayub kamranayub added the bug This issue describes undesirable, incorrect, or unexpected behavior label Feb 28, 2020
@kamranayub kamranayub self-assigned this Feb 28, 2020
@kamranayub kamranayub added this to the 0.24.0 Release milestone Feb 28, 2020
@kamranayub
Copy link
Member Author

Quick update to this: it's still an issue in master but only reproducible when you try to attach an event handler during Scene.onInitialize

@eonarheim
Copy link
Member

eonarheim commented Feb 28, 2020 via email

@jedeen jedeen modified the milestones: 0.24.0 Release, 0.25.0 Release Apr 24, 2020
@eonarheim eonarheim added potential-hacktoberfest Hacktoberfest Issues marked for the community Hacktoberfest event https://hacktoberfest.digitalocean.com/ and removed potential-hacktoberfest labels Sep 30, 2020
@github-actions
Copy link

This issue hasn't had any recent activity lately and is being marked as stale automatically.

@github-actions github-actions bot added the stale This issue or PR has not had any activity recently label Dec 27, 2020
@eonarheim
Copy link
Member

eonarheim commented Jun 5, 2021

~~It's possible this will be fixed by #1890 #1900 ~~ Nope, fixed in #1925

@github-actions github-actions bot removed the stale This issue or PR has not had any activity recently label Jun 6, 2021
eonarheim added a commit that referenced this issue Jun 9, 2021
eonarheim added a commit that referenced this issue Jun 9, 2021
Closes #1439

## Changes:

- Emit event at engine pointers level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior Hacktoberfest Issues marked for the community Hacktoberfest event https://hacktoberfest.digitalocean.com/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants