Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log limit @obsolete decorator #1281

Closed
eonarheim opened this issue Oct 8, 2019 · 0 comments · Fixed by #1282
Closed

Log limit @obsolete decorator #1281

eonarheim opened this issue Oct 8, 2019 · 0 comments · Fixed by #1282
Labels
core team This issue should be done by an Excalibur core member enhancement Label applied to enhancements or improvements to existing features
Milestone
0.24.0 Release

Comments

@eonarheim
Copy link
Member

Context

Currently the @obsolete decorator will log every time a method, getter/setter, or class is called. This can cause the browser to lock up, or test result logs to be filled with obsolete messages.

Proposal

Log limit the @obsolete decorator so that the same message from a method can only be logged 5 times.
@eonarheim eonarheim added core team This issue should be done by an Excalibur core member chore Maintenance tasks, like upgrading libraries or release tasks enhancement Label applied to enhancements or improvements to existing features and removed chore Maintenance tasks, like upgrading libraries or release tasks labels Oct 8, 2019
eonarheim added a commit that referenced this issue Oct 9, 2019
@eonarheim
[#1281] Limit obsolete decorator to 5 messages
af13bed 
Closes #1281
@eonarheim eonarheim mentioned this issue Oct 9, 2019
Merged
5 tasks
eonarheim added a commit that referenced this issue Oct 30, 2019
@eonarheim
[#1281] Limit obsolete decorator to 5 messages (#1282)
ae331b4 
Closes #1281

## Changes:

- Update `@obsolete() decorator to only log 5 messages that are the same.
- Update tests
@eonarheim eonarheim mentioned this issue Apr 24, 2020
Open
55 tasks
@jedeen jedeen added this to the 0.24.0 Release milestone Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core team This issue should be done by an Excalibur core member enhancement Label applied to enhancements or improvements to existing features
Projects
None yet
Milestone
0.24.0 Release
Development

Successfully merging a pull request may close this issue.

[#1281] Limit obsolete decorator to 5 messages excaliburjs/Excalibur
2 participants
@eonarheim @jedeen