fix: Particle instance leak if ParticleEmitter killed during emission

excaliburjs · Nov 23, 2024 · 70d979b · 70d979b
1 parent ca3d277
commit 70d979b
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/engine/Particles/Particles.ts b/src/engine/Particles/Particles.ts
@@ -124,9 +124,11 @@ export class Particle extends Entity {
     }
   }
 
-  public kill() {
-    if (this._emitter) {
+  public override kill() {
+    if (this._emitter?.active) {
       this._emitter.removeParticle(this);
+    } else {
+      super.kill();
     }
   }