Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#381 Migrated from version.sh to artifact-reference-checker-maven-plugin #383

Merged
merged 4 commits into from
Sep 9, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@ addons:
sonarcloud:
organization: exasol

before_script:
- tools/version.sh verify

install:
- travis_retry mvn dependency:resolve

Expand Down
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ Running the Virtual Schema requires a Java Runtime version 9 or later.
| [Maven Surefire Plugin](https://maven.apache.org/surefire/maven-surefire-plugin/) | Unit testing | Apache License 2.0 |
| [Sonatype OSS Index Maven Plugin][sonatype-oss-index-maven-plugin] | Checking Dependencies Vulnerability | ASL2 |
| [Versions Maven Plugin][versions-maven-plugin] | Checking if dependencies updates are available | Apache License 2.0 |
| [Artifact Reference Checker Plugin][artifact-reference-checker-plugin] | Check if artifact is referenced with correct version | MIT License |

[maven-assembly-plugin]: https://maven.apache.org/plugins/maven-assembly-plugin/
[apache-trift]: http://thrift.apache.org/
Expand Down Expand Up @@ -186,4 +187,5 @@ Running the Virtual Schema requires a Java Runtime version 9 or later.
[sap-hana-dialect-doc]: doc/dialects/saphana.md
[sql-server-dialect-doc]: doc/dialects/sql_server.md
[sybase-dialect-doc]: doc/dialects/sybase.md
[teradata-dialect-doc]: doc/dialects/teradata.md
[teradata-dialect-doc]: doc/dialects/teradata.md
[artifact-reference-checker-plugin]: https://github.com/exasol/artifact-reference-checker-maven-pluginm
jakobbraun marked this conversation as resolved.
Show resolved Hide resolved
13 changes: 10 additions & 3 deletions doc/changes/changes_4.0.4.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,20 @@
# Exasol Virtual Schemas 4.0.4, released 2020-??-??

Code name:

## Documentation

#371: Documented data types conversion for Hive dialect.
* #371: Documented data types conversion for Hive dialect.

## Features / Enhancements

* #381: Migrated from version.sh to artifact-reference-checker-maven-plugin

## Refactoring

#263: Removed SybaseMetadataReader class as it was not used by the dialect.
* #263: Removed SybaseMetadataReader class as it was not used by the dialect.

## Dependency updates

* Updated `org.apache.hbase:hbase-server` from 2.3.0 to 2.3.1
* Updated `org.apache.hbase:hbase-server` from 2.3.0 to 2.3.1
* Added com.exasol:artifact-reference-checker-maven-plugin:0.3.0
16 changes: 1 addition & 15 deletions doc/development/versioning.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,4 @@

All dialects have the same version as the master project. In the master `pom.xml` file a property called `product-version` is set. Use this in as the artifact version number in the JDBC adapter and all dialects.

Run the script

```bash
jdbc-adapter/tools/version.sh verify
```

To check that all documentation and templates reference the same version number. This script is also used as a build breaker in the continuous integration script.

To update documentation files run

```bash
jdbc-adapter/tools/version.sh unify
```

Note that the script must be run from the root directory of the virtual schema project.
This project uses the [artifact-reference-checker-maven-plugin](https://github.com/exasol/artifact-reference-checker-maven-plugin/) to validate and unify references from source code.
9 changes: 0 additions & 9 deletions launch/vs unify versions.launch

This file was deleted.

17 changes: 17 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,23 @@
</execution>
</executions>
</plugin>
<plugin>
<groupId>com.exasol</groupId>
<artifactId>artifact-reference-checker-maven-plugin</artifactId>
<version>0.3.0</version>
<executions>
<execution>
<goals>
<goal>verify</goal>
</goals>
</execution>
</executions>
<configuration>
<excludes>
<exclude>/doc/changes/*</exclude>
</excludes>
</configuration>
</plugin>
</plugins>
</build>
</project>
116 changes: 0 additions & 116 deletions tools/version.sh

This file was deleted.