Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#314: implemented switch for IMPORT statement for BigQuery dialect #315

Merged
merged 7 commits into from
Feb 18, 2020
Merged

#314: implemented switch for IMPORT statement for BigQuery dialect #315

merged 7 commits into from
Feb 18, 2020

Conversation

AnastasiiaSergienko
Copy link
Contributor

Closes #314

@AnastasiiaSergienko AnastasiiaSergienko added the feature Product feature label Feb 14, 2020
@AnastasiiaSergienko AnastasiiaSergienko self-assigned this Feb 14, 2020
redcatbear
redcatbear approved these changes Feb 17, 2020
View reviewed changes
Copy link
Collaborator

@redcatbear redcatbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one more text change pending.

src/main/java/com/exasol/adapter/dialects/bigquery/BigQuerySqlDialect.java Outdated Show resolved Hide resolved
redcatbear
redcatbear requested changes Feb 17, 2020
View reviewed changes
doc/dialects/bigquery.md Outdated Show resolved Hide resolved
doc/dialects/bigquery.md Outdated Show resolved Hide resolved
AnastasiiaSergienko and others added 3 commits February 17, 2020 16:03
@AnastasiiaSergienko @redcatbear
Apply suggestions from code review
bb98a5f 
Co-Authored-By: Sebastian Bär <[email protected]>
@AnastasiiaSergienko
#314: fixed review findings
c92dc78
@AnastasiiaSergienko
Merge remote-tracking branch 'origin/feature/314_implement_switch_for…
660cee5 
…_bigquery_import' into feature/314_implement_switch_for_bigquery_import
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

92.3% 92.3% Coverage
0.0% 0.0% Duplication

@AnastasiiaSergienko AnastasiiaSergienko merged commit 89f9d5e into master Feb 18, 2020
@AnastasiiaSergienko AnastasiiaSergienko deleted the feature/314_implement_switch_for_bigquery_import branch February 18, 2020 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redcatbear redcatbear redcatbear approved these changes

Assignees

@AnastasiiaSergienko AnastasiiaSergienko

Labels
feature Product feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement a switch for BigQuery to enable IMPORT statement
2 participants
@AnastasiiaSergienko @redcatbear