Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map SQL Server Clob (ntext, text, clob) to 2 mb varchar #123

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Map SQL Server Clob (ntext, text, clob) to 2 mb varchar #123

merged 1 commit into from
Apr 1, 2019

Conversation

Sargul
Copy link
Contributor

@Sargul Sargul commented Mar 26, 2019

@Sargul
Copy link
Contributor Author

Sargul commented Mar 28, 2019

Travis failed because of:
Unable to execute SonarQube: Fail to get bootstrap index from server: Failed to connect to localhost/127.0.0.1:9000: Connection refused (Connection refused) -> [Help 1]

There nothing I can do about this. Any suggestions?

@snehlsen
Copy link
Contributor

Looks like a transient failure, I restarted the CI build.

@redcatbear
Copy link
Collaborator

Restarted build.

redcatbear
redcatbear approved these changes Mar 28, 2019
View reviewed changes
Copy link
Collaborator

@redcatbear redcatbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change approved with no findings.

@redcatbear
Copy link
Collaborator

Unfortunately Sonar only works from project internal pull request. If you fork to your private repository and then create a PR, Sonar refuses to work.

@redcatbear redcatbear self-assigned this Mar 28, 2019
@redcatbear redcatbear added the bug Unwanted / harmful behavior label Mar 28, 2019
@redcatbear
Copy link
Collaborator

redcatbear commented Mar 28, 2019 •
edited
Loading

@Sargul, please

  1. increment the last digit of the version number in the property to <product.version>1.8.3</product.version> in virtual-schemas/jdbc-adapter/pom.xml.
  2. run 
    jdbc-adapter/tools/version.sh unify
  3. Commit new version to your branch

@AnastasiiaSergienko
Copy link
Contributor

Since we update the version in #127 to 1.9.0, we merge this now. Will be part of v1.9.0 then.

@AnastasiiaSergienko AnastasiiaSergienko merged commit 4d24724 into exasol:master Apr 1, 2019
redcatbear added a commit that referenced this pull request Apr 11, 2019
@redcatbear
#123: Improved how schemas identify support for structural elements. …
ecfb780 
…Reading metadata now filters by catalog and schema.
redcatbear added a commit that referenced this pull request May 3, 2019
@redcatbear
Enhancement/162 automatically register sql dialect adapters (#165)
d947f2c 
* #45: Rewrote parts of the JDBC adapter to use the new `common` code.
* #121: Used new request dispatching from `common`
* #123: Improved how schemas identify support for structural elements
* #131: Refactored metadata reading
* #155: moved property validation logic to dialects
* #162: Automatically register SQL dialects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redcatbear redcatbear redcatbear approved these changes

Assignees

@redcatbear redcatbear

Labels
bug Unwanted / harmful behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sargul @snehlsen @redcatbear @AnastasiiaSergienko