Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEXT type for MySQL dialect #320

Closed
redcatbear opened this issue Mar 18, 2020 · 1 comment · Fixed by #323
Closed

TEXT type for MySQL dialect #320

redcatbear opened this issue Mar 18, 2020 · 1 comment · Fixed by #323
Assignees
@redcatbear @AnastasiiaSergienko
Labels
bug Unwanted / harmful behavior

Comments

@redcatbear
Copy link
Collaborator

redcatbear commented Mar 18, 2020 •
edited
Loading

Situation

MySQL knows the type TEXT which can hold large amounts of text. Exasol's closest match is VARCHAR. At least documents up to 2 million characters should be usable through the MySQL dialect for Exasol Virtual Schema.

Acceptance Criteria

  • UTF text from MySQL TEXT columns visible as VARCHAR in VS (up to maximum Exasol VARCHAR size).
@redcatbear redcatbear added the bug Unwanted / harmful behavior label Mar 18, 2020
@redcatbear redcatbear self-assigned this Mar 18, 2020
@redcatbear
Copy link
Collaborator Author

Looking at the code the BaseColumnMetadataReader already handles LONGVARCHAR correctly. And that is what the MySQL JDBC driver maps TEXT fields to.

See:

@redcatbear redcatbear mentioned this issue Mar 19, 2020
Closed
@AnastasiiaSergienko AnastasiiaSergienko self-assigned this Mar 27, 2020
AnastasiiaSergienko added a commit that referenced this issue Mar 27, 2020
@AnastasiiaSergienko
#320: hardcoded the size of MySQL data type TEXT because the driver c…
01ed2cf 
…an return an incorrect value.
@AnastasiiaSergienko AnastasiiaSergienko mentioned this issue Mar 27, 2020
Merged
AnastasiiaSergienko added a commit that referenced this issue Mar 30, 2020
@AnastasiiaSergienko
#320: fixed review findings and adjusted documentation for MySQL dialect
52a6820
AnastasiiaSergienko added a commit that referenced this issue Mar 30, 2020
@AnastasiiaSergienko
#320: fixed review findings
443ed73
AnastasiiaSergienko added a commit that referenced this issue Mar 30, 2020
@AnastasiiaSergienko
#320: hardcoded the size of MySQL data type TEXT (#323)
62f1ff2 
* #320: hardcoded the size of MySQL data type TEXT because the driver can return an incorrect value.
* #320: fixed review findings and adjusted documentation for MySQL dialect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@redcatbear redcatbear

@AnastasiiaSergienko AnastasiiaSergienko

Labels
bug Unwanted / harmful behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#320: hardcoded the size of MySQL data type TEXT exasol/virtual-schemas
2 participants
@redcatbear @AnastasiiaSergienko