#300: fixed review findings

exasol · Jan 22, 2020 · 6966494 · 6966494
1 parent 4ac5d67
commit 6966494
Show file tree

Hide file tree

Showing 3 changed files with 387 additions and 364 deletions.
diff --git a/pom.xml b/pom.xml
@@ -215,6 +215,7 @@
             <scope>test</scope>
         </dependency>
         <!--From here: legacy dependencies that should be checked later (most of them were used in old integration tests)-->
+        <!--https://github.com/exasol/virtual-schemas/issues/302-->
         <dependency>
             <groupId>org.skyscreamer</groupId>
             <artifactId>jsonassert</artifactId>

diff --git a/src/test/java/com/exasol/adapter/dialects/IntegrationTestsConstants.java b/src/test/java/com/exasol/adapter/dialects/IntegrationTestsConstants.java
@@ -4,9 +4,18 @@
 
 public final class IntegrationTestsConstants {
     public static final String VIRTUAL_SCHEMAS_JAR_NAME_AND_VERSION = "virtualschema-jdbc-adapter-dist-3.0.1.jar";
-    public static final Path PATH_TO_VIRTUAL_SCHEMAS_JAR = Path.of("target/" + VIRTUAL_SCHEMAS_JAR_NAME_AND_VERSION);
+    public static final Path PATH_TO_VIRTUAL_SCHEMAS_JAR = Path.of("target", VIRTUAL_SCHEMAS_JAR_NAME_AND_VERSION);
     public static final String SCHEMA_EXASOL_TEST = "SCHEMA_EXASOL_TEST";
     public static final String ADAPTER_SCRIPT_EXASOL = "ADAPTER_SCRIPT_EXASOL";
     public static final String TABLE_JOIN_1 = "TABLE_JOIN_1";
     public static final String TABLE_JOIN_2 = "TABLE_JOIN_2";
+
+    public static final String POSTGRES_DRIVER_NAME_AND_VERSION = "postgresql-42.2.5.jar";
+    public static final Path PATH_TO_POSTGRES_DRIVER = Path.of("src", "test", "resources", "integration", "driver",
+            POSTGRES_DRIVER_NAME_AND_VERSION);
+    public static final String POSTGRES_DOCKER_VERSION = "postgres:9.6.2";
+
+    private IntegrationTestsConstants() {
+        // intentionally left empty
+    }
 }