Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation improvements #199

Merged

Conversation

MarleneKress79789
Copy link
Collaborator

@MarleneKress79789 MarleneKress79789 commented Feb 22, 2024

All Submissions:

README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@tkilias tkilias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments and please change the target branch to the dev branch

README.md Outdated Show resolved Hide resolved
buildspec.yml Show resolved Hide resolved
doc/developer_guide/developer_guide.md Outdated Show resolved Hide resolved
doc/developer_guide/developer_guide.md Outdated Show resolved Hide resolved
doc/developer_guide/developer_guide.md Outdated Show resolved Hide resolved
doc/user_guide/user_guide.md Outdated Show resolved Hide resolved
doc/user_guide/user_guide.md Outdated Show resolved Hide resolved
doc/user_guide/user_guide.md Outdated Show resolved Hide resolved
doc/user_guide/user_guide.md Outdated Show resolved Hide resolved
doc/user_guide/user_guide.md Outdated Show resolved Hide resolved
@MarleneKress79789 MarleneKress79789 changed the base branch from main to dev_storage_format_change March 26, 2024 12:31
pyproject.toml Outdated Show resolved Hide resolved
download the model from Hugging Face to the Database without saving it somewhere else intermittently.
If you are using the Exasol DockerDB, this is not the case by default, and you need to specify a name server.
For example setting it to 'nameserver = 8.8.8.8' will set it to use Google DNS.
You will need to used [ConfD](https://docs.exasol.com/db/latest/confd/confd.htm) to do this,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You will need to used [ConfD](https://docs.exasol.com/db/latest/confd/confd.htm) to do this,
You will need to use [ConfD](https://docs.exasol.com/db/latest/confd/confd.htm) to do this,

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ConfD is not only necessary for DockerDb, but also for a v8 setup via c4

@MarleneKress79789 MarleneKress79789 merged commit 7018bd2 into dev_storage_format_change Apr 2, 2024
3 checks passed
@MarleneKress79789 MarleneKress79789 deleted the documentation/133_improve_docu branch April 2, 2024 13:50
tkilias added a commit that referenced this pull request Apr 12, 2024
MarleneKress79789 added a commit that referenced this pull request Apr 12, 2024
* Refactoring/#146 use new model save functionality (#186)
* switched use to huggingface transfer save pretrained version
* changed to load local model
* removed download sample model fixture because of duplication
* #147: Removed huggingface token from model loading (#203)
* removed token_conn everywhere except model download and tests
* removed token_conn from relevant tests
* Documentation improvements (#199)
* Prepared release 1.0.0 (#206)

Co-authored-by: Torsten Kilias <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve description of BucketFS Con Improve documentation with missing info and better readability
2 participants