#166: Fix language definition generation under Windows #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't test this case, because for that, we would need to run the under windows. |
ckunki
previously approved these changes
Feb 19, 2024
| @@ -228,7 +228,7 @@ def _generate_new_language_settings(self, path_in_udf: PurePosixPath, | |||
| other_definitions = [ | |||
| alias_definition for alias_definition in prev_lang_aliases | |||
| if not alias_definition.startswith(self._language_alias + "=")] | |||
| path_in_udf_without_bucksts = Path(*path_in_udf.parts[2:]) | |||
| path_in_udf_without_bucksts = PurePosixPath(*path_in_udf.parts[2:]) | |||
There was a problem hiding this comment.
What does "bucksts" stand for or is it a typo?
ckunki
previously approved these changes
Feb 19, 2024
…ng_slc_under_windows
…ng_slc_under_windows
ckunki
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #166
All Submissions:
[CodeBuild]to the commit message